Upgrade to sbt 1.2.3, properly report problems to sbt #5106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
proper-sbt-reporting-3
branch
2 times, most recently
from
1b761b6 to
10d1cdb
Compare
OlivierBlanvillain
approved these changes
Sep 14, 2018
project/Build.scala
Outdated
| @@ -928,6 +928,7 @@ object Build { | |||
| // sbt plugin to use Dotty in your own build, see | |||
| // https://github.com/lampepfl/dotty-example-project for usage. | |||
| lazy val `sbt-dotty` = project.in(file("sbt-dotty")). | |||
| enablePlugins(ScriptedPlugin). | |||
There was a problem hiding this comment.
Should we use the newer SbtPlugin?
|
We should experiment with sbt/sbt#3891. It introduces two new options to the scripted tests:
|
smarter
force-pushed
the
proper-sbt-reporting-3
branch
3 times, most recently
from
ca685e8 to
9a96668
Compare
We cannot use sbtVersion.value for compiler-interface and zinc-api-info anymore because sbt 1.2.3 uses Zinc 1.2.2
smarter
force-pushed
the
proper-sbt-reporting-3
branch
2 times, most recently
from
3af53c8 to
4800292
Compare
|
We're getting a ClassCastException in the scripted test but it's probably harmless: sbt/sbt#4361 |
Looks like a no go. |
|
Also before that there is:
|
|
Too bad. No speedup for the scripted tests then... |
The new image has updated dependencies and is based on Ubuntu instead of Alpine.
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
force-pushed
the
proper-sbt-reporting-3
branch
2 times, most recently
from
e090a29 to
cbff210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.